Frozen Functions Fixes #121
Merged
+96
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed memory leaks when freezing vcall.cpp Updated comments for all variant registry traversal Added domain_name to jit_registry_get_pointers Reverted on all domain registry traversal Fixed memory leaks when dry-running with captured variables Fixed memory leaks when dry-running aggregate calls Added state, literal, data and unaligned to VarInfo Fixed compilation failure on mac
DoeringChristian
force-pushed
the
frozen-functions-fixes
branch
from
3455c15 to
057c8a9
Compare
njroussel
approved these changes
Feb 4, 2025
|
Looks good to me ! We're in the middle of a release, we'll wait for it to be done before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various fixes to the
Frozen ThreadState#107 PR, that appeared after merging.capture_call_offsetfunctionvcalltests by freeing the copied OptiX SBT and changingborrowtostealin testThis PR replaces #115, and changes the source branch.