Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP Authentication #792

Merged
merged 45 commits into from
Feb 1, 2021
Merged

Add LDAP Authentication #792

merged 45 commits into from
Feb 1, 2021

Conversation

camdenmoors
Copy link
Collaborator

@camdenmoors camdenmoors commented Jan 21, 2021

Closes #679, adds the ability to login using LDAP. Configuration is set in .env as follows:

LDAP_ENABLED: Choose whether or not to use ldap (True/False)
LDAP_HOST: Your target LDAP server (Default 389)
LDAP_BINDDN: User account used to query account lookups
LDAP_PASSWORD: Password for user account used to query account lookups
LDAP_SEARCHBASE: The location to search within LDAP (AD Users would use "OU=Users, DC=<yourdomain>, DC=local")
LDAP_SEARCHFILTER: LDAP search filter (AD Users would use sAMAccountName={{username}})
LDAP_NAMEFIELD: The field that contains the user's name (default is 'name', works for AD)
LDAP_MAILFIELD: The field that contains the user's email (default is 'mail', works for AD)

@camdenmoors camdenmoors marked this pull request as draft January 21, 2021 16:31
@camdenmoors
Copy link
Collaborator Author

camdenmoors commented Jan 21, 2021

Converting to a draft until I finish tests

apps/frontend/src/views/Login.vue Outdated Show resolved Hide resolved
apps/frontend/src/views/Login.vue Outdated Show resolved Hide resolved
@robthew robthew temporarily deployed to mitre-heimda-ldap-df2aqlzsf9jr January 21, 2021 17:24 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 21, 2021 17:37 Inactive
@camdenmoors camdenmoors marked this pull request as ready for review January 21, 2021 17:47
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 21, 2021 17:47 Inactive
@camdenmoors camdenmoors marked this pull request as draft January 21, 2021 17:48
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 21, 2021 18:00 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 21, 2021 18:54 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2021

This pull request introduces 1 alert when merging d079468 into 7d6f687 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 21, 2021 19:02 Inactive
Copy link
Collaborator Author

@camdenmoors camdenmoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not mean to start a review. Hopefully commenting will let me remove this

@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 21, 2021 19:05 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 22, 2021 15:13 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 22, 2021 15:31 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 28, 2021 16:01 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 28, 2021 16:17 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 28, 2021 16:24 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 28, 2021 16:49 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 28, 2021 16:50 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 28, 2021 19:05 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 28, 2021 19:46 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 January 29, 2021 14:10 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 February 1, 2021 14:41 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 February 1, 2021 17:18 Inactive
@robthew robthew temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 February 1, 2021 17:59 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-ldap-a2kklfm3fcr7 February 1, 2021 19:11 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rbclark rbclark merged commit 2b00212 into master Feb 1, 2021
@rbclark rbclark deleted the LDAP branch February 1, 2021 19:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for LDAP user authentication
3 participants