Docker improvements #6075
Merged
Docker improvements #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Amndeep7
commented
Aug 6, 2024
•
Amndeep7
commented
- Simplify dockerfile by doing the chown/chmod on copy
- Try out macos runner - not possible see 857ba1f
- Multiarch docker build - not feasible, just heimdall lite is over 3.75hrs and going
- Try out to see if we can use matrixes to combine the workflows for push-latest vs release and heimdall-lite vs heimdall
- Try using the docker metadata action to generate the tag info instead of using some random string manipulation action
… to save a lot of space by not having duplicate layers Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
… the setup buildx command earlier since it'll hopefully install docker then Signed-off-by: Amndeep Singh Mann <[email protected]>
…w am experimenting with QEMU to do the emulation. Turns out that we need at least macos-15 and m3 chip runners in order to support virtualization properly. Currently, the runner version is on 14 and m1. Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.