Skip to content

Remove Tag Cleaning on Frontend #6052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove Tag Cleaning on Frontend #6052

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95d4d3e
Clean up tags
charleshu-8 Aug 1, 2024
13341ba
Merge branch 'master' into renderTagHTML
charleshu-8 Aug 1, 2024
9ea6714
Undo tag cleaning
charleshu-8 Aug 1, 2024
782225f
Merge branch 'master' into renderTagHTML
charleshu-8 Aug 22, 2024
675c32e
Merge branch 'master' into renderTagHTML
charleshu-8 Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libs/hdf-converters/src/converters-from-hdf/html/reverse-html-mapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
IResultSeverity,
IResultStatus
} from './html-types';
import {cleanTags} from '../../utils/global';

type InputData = {
data: ContextualizedEvaluation | string;
Expand Down Expand Up @@ -416,6 +417,14 @@ export class FromHDFToHTMLMapper {
.map((control) => (control === 'unmapped' ? 'UM-1' : control))
.filter((control) => control !== 'Rev_4');

// Clean up possible tags that may get passed from the OHDF file
result.hdf.wraps.title = result.hdf.wraps.title
? cleanTags(result.hdf.wraps.title)
: '';
result.hdf.wraps.desc = result.hdf.wraps.desc
? cleanTags(result.hdf.wraps.desc)
: '';

// Assign attributes
return {
..._.set(
Expand Down
6 changes: 6 additions & 0 deletions libs/hdf-converters/src/utils/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,9 @@ export function ensureContextualizedEvaluation(
return contextualizeEvaluation(data);
}
}

// Clean up any unescaped tags
export function cleanTags(text: string) {
return new DOMParser().parseFromString(text, 'text/html').documentElement
.textContent;
}