Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoSec Mapper impact Fix #5952

Merged
merged 2 commits into from
Jul 2, 2024
Merged

GoSec Mapper impact Fix #5952

merged 2 commits into from
Jul 2, 2024

Conversation

charleshu-8
Copy link
Contributor

  • Fix impact to refer to GoSec's severity field.
  • Other minor adjustments to mapper.

Signed-off-by: Charles Hu <[email protected]>
@charleshu-8 charleshu-8 added bug Something isn't working hdf-converters Issue related to the HDF Converters library labels Jul 1, 2024
@charleshu-8 charleshu-8 self-assigned this Jul 1, 2024
@charleshu-8
Copy link
Contributor Author

Code smells are commented out lines for printing test files. Disregard.

Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually changed one of the results in the sample file to have LOW severity. This caused the entire G304 section to be changed to LOW severity even though the other ones were at MEDIUM severity. We need to determine if it is necessary to actually restructure this mapper so that the results are not consolidated by 'id' since even though metadata like severity is probably not gonna change due to being tied to the CWE, other metadata like confidence probably could change per result. I think we should probably generate more sample files since the provided sample is not sufficient.

@Amndeep7 Amndeep7 merged commit 744445a into master Jul 2, 2024
17 checks passed
@Amndeep7 Amndeep7 deleted the gosecImpact branch July 2, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hdf-converters Issue related to the HDF Converters library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants