-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package.json Fix #5727
Merged
Merged
Package.json Fix #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMedina6
requested review from
wdower,
Amndeep7,
aaronlippold,
georgedias and
em-c-rod
April 15, 2024 19:29
em-c-rod
reviewed
Apr 15, 2024
em-c-rod
reviewed
Apr 15, 2024
Amndeep7
previously requested changes
Apr 15, 2024
em-c-rod
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like Amndeep's suggestion and otherwise approve of these changes. Thanks!
georgedias
approved these changes
Apr 16, 2024
georgedias
approved these changes
Apr 16, 2024
georgedias
added
the
ready-to-merge
Used by mergify to identify if a PR is ready to merge into master.
label
Apr 16, 2024
georgedias
approved these changes
Apr 16, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the package.json file to use the .env file located in ./apps/backend/ rather than the root directory.
This also modifies the readme to be more explicit about which .env is being used and where it's located for both dockerized and locally hosted application builds.
Documentation was previously unclear and stated that the .env file in ./apps/backend/ is what is used for local builds even though it was actually pulling from the .env in the root directory?