Upgrade node to 14.x in GH Actions #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 7, 2020 12:28
Docker is building on node 14.x however the test suite is running on 12.x. Failures are happening on Docker and not on the test suite, this makes the versions consistent in order to attempt to avoid such errors.
vue-cli-service v4 is trying to run eslint on build and was failing since it couldn't find our prettierrc config.
This is a suggested step as part of the vue-cli-service upgrade, https://cli.vuejs.org/migrating-from-v3/
|
Kudos, SonarCloud Quality Gate passed!
|
Bialogs
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker is building on node 14.x however the test suite is running on 12.x. Failures are happening on Docker and not on the test suite, this makes the versions consistent in order to attempt to avoid such errors.
Also run vue upgrade and move appropriate deps from devDependencies. This is a suggested step as part of the vue-cli-service upgrade, https://cli.vuejs.org/migrating-from-v3/