Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a warning banner using the backend WARNING_BANNER env variable #240

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Add support for a warning banner using the backend WARNING_BANNER env variable #240

merged 2 commits into from
Sep 25, 2020

Conversation

rbclark
Copy link
Contributor

@rbclark rbclark commented Sep 25, 2020

Fixes #236

@rbclark rbclark force-pushed the addWarningBanner branch 2 times, most recently from 8c3308c to ca66ce7 Compare September 25, 2020 17:01
@robthew robthew temporarily deployed to mitre-heimda-addwarning-bmfmaa September 25, 2020 17:12 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addwarning-bmfmaa September 25, 2020 17:16 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addwarning-bmfmaa September 25, 2020 17:41 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addwarning-bmfmaa September 25, 2020 17:44 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rbclark rbclark merged commit 3240c69 into master Sep 25, 2020
@rbclark rbclark deleted the addWarningBanner branch September 25, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bialogs Bialogs Bialogs approved these changes

@ejaronne ejaronne Awaiting requested review from ejaronne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo warning for herokuapp instances
3 participants
@rbclark @Bialogs @robthew