Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add run command for Heroku #206

Merged
merged 7 commits into from
Sep 23, 2020
Merged

Add run command for Heroku #206

merged 7 commits into from
Sep 23, 2020

Conversation

rbclark
Copy link
Contributor

@rbclark rbclark commented Sep 22, 2020

By default, Heroku expects a run command to be provided (yarn run start). This adds such a command for Heroku.

@rbclark rbclark marked this pull request as draft September 22, 2020 21:25
@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2020

This pull request introduces 2 alerts when merging b758da2876b99c29da4fbad3811774d584d307a2 into 37710e8 - view on LGTM.com

new alerts:

  • 2 for Syntax error

@robthew robthew temporarily deployed to mitre-heimda-addruncomm-qm815b September 23, 2020 13:11 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 14:20 Inactive
@robthew robthew temporarily deployed to mitre-heimdall-staging September 23, 2020 17:25 Inactive
@robthew robthew temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 17:44 Inactive
@robthew robthew temporarily deployed to mitre-heimdall-staging September 23, 2020 17:45 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 17:56 Inactive
@rbclark rbclark temporarily deployed to mitre-heimdall-staging September 23, 2020 18:07 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 19:23 Inactive
@rbclark rbclark temporarily deployed to mitre-heimdall-staging September 23, 2020 20:21 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 21:07 Inactive
@rbclark rbclark temporarily deployed to mitre-heimdall-staging September 23, 2020 21:07 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 21:43 Inactive
@rbclark rbclark temporarily deployed to mitre-heimdall-staging September 23, 2020 21:43 Inactive
Robert Clark and others added 6 commits September 23, 2020 17:45
Add run command for Heroku
285aae6 
By default, Heroku expects a run command to be provided (yarn run start). This adds such a command for Heroku.
Parse DATABASE_URL into components for Nest. Allow DATABASE_URL to be…
c0327df 
… provided for .sequelizerc
Fix syntax error in config.service. Add tests for new database_url pa…
38b5143 
…rsing code.
@robthew
edited start
c1710d7
Rename HEIMDALL_SERVER_PORT to PORT
710c73a
url will either be DATABASE_URL if provided via process.env to overri…
3e403f9 
…de anything in the .env file (or from the env file). Run linter.
@rbclark rbclark temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 21:46 Inactive
@rbclark rbclark temporarily deployed to mitre-heimdall-staging September 23, 2020 21:48 Inactive
@rbclark rbclark marked this pull request as ready for review September 23, 2020 21:56
@rbclark rbclark temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 21:56 Inactive
@rbclark rbclark temporarily deployed to mitre-heimda-addruncomm-nfyzno September 23, 2020 22:01 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rbclark rbclark temporarily deployed to mitre-heimdall-staging September 23, 2020 22:02 Inactive
@rbclark rbclark merged commit 096c5a1 into master Sep 23, 2020
@aaronlippold aaronlippold deleted the addRunCommand branch October 31, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlippold aaronlippold aaronlippold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbclark @aaronlippold @robthew