User agent order #647
Open
User agent order #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a request User-Agent will match a Bad User-Agents, the Good User-Agents are never checked. Sure, you can use bots.d/blacklist-user-agents.conf, but for something generic that you want to whitelist on all servers I consider this approach simpler.
Revolut payment processing uses "Revolut-Octopus/1.0" User-Agent to send callbacks. These requests are blocked by the "Octopus" bad User-Agent rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We ran into an issue with the User-Agent rules order.
The block rule on Octopus User-Agent is matched before L491 any good User-Agents can match L848. Considering that the bad User-Agents are matched before the Good ones, I propose that we move the bad User-Agents after the good and rate limited ones.
In the process, I also added Revolut-Octopus as a good User-Agent.