update-ngxblocker (local - bad variable name) Ubuntu 16.04

[mitchellkrogza]

@itoffshore weird one here ???

/usr/sbin/update-ngxblocker -x -b /etc/nginx/bots2.d -c /etc/nginx/conf2.d -n
/usr/sbin/update-ngxblocker: 107: local: /etc/nginx/conf.d: bad variable name

Distributor ID: Ubuntu
Description:    Ubuntu 16.04.2 LTS
Release:        16.04
Codename:       xenial

[itoffshore]

I think this is an incompatibility with the dash shell.

if you temporarily change the script header to #!/bin/bash it will probably work.

Will try & find the problem

[mitchellkrogza]

Hang on let me run with bash ./update-ngblocker and see what happens or actually dash ./update-ngblocker ??

[mitchellkrogza]

bash /usr/sbin/update-ngxblocker -x -b /etc/nginx/bots2.d -c /etc/nginx/conf2.d -n
ERROR: Missing directory: /etc/nginx/bots.d => running /usr/sbin/install-ngxblocker:
update-ngxblocker: UPDATE Nginx Bad Bot Blocker blacklist in: [ /etc/nginx/conf.d ]

Usage: update-ngxblocker [OPTIONS]
        [ -c ] : NGINX conf directory          (default: /etc/nginx/conf.d)
        [ -b ] : NGINX bots directory          (default: /etc/nginx/bots.d)
        [ -i ] : Change installer path         (default: /usr/sbin/install-ngxblocker)
        [ -r ] : Change repo url               (default: https://raw.githubusercontent.com/mitchellkrogza/nginx-ultimate-bad-bot-blocker/master)
        [ -e ] : Change email address          (default: me@myemail.com)
        [ -n ] : Do not send email report      (default: Y)
        [ -v ] : Print blacklist version
        [ -h ] : this help message

Examples:
 update-ngxblocker                         (Download globalblacklist.conf to: /etc/nginx/conf.d)
 update-ngxblocker -c /my/custom/conf.d    (Download globalblacklist.conf to a custom location)
 update-ngxblocker -b /my/custom/bots.d    (Download globalblacklist.conf & update with your custom bots.d location)
 update-ngxblocker -e yourname@youremailaddress.com (Download globalblacklist.conf specifying your email address for the notification)
 update-ngxblocker -u /path/to/install-ngxblocker   (Use custom path to install-ngxblocker to update bots.d / conf.d include files)

[mitchellkrogza]

Works executing it with bash but see the problem about ERROR: Missing directory when I specified a different directory in the command line ??

[mitchellkrogza]

@itoffshore also for some reason the setup script does not go and change the include locations in globalblacklist.conf and I know it worked before. I'm a bit stumped on this one.

[itoffshore]

part of the problem was you using -x when there is no option for it (which is why it showed help)

I've found the issue with dash - it needs $@ quoted - will fix in a new PR