support for folder sync via rsync on windows.

[databus23]

rsync interprets paths with colons as remote locations.
This leads to "The source and destination cannot both be remote." erros when using local paths like c:\vagrant for the hostpath.
This commits converts the hostpath to /cygdrive/... notation on windows in general.
I confirmed that this works with the cwRsync Installer (https://www.itefix.no/i2/cwrsync).

[danrex]

+1. I am running into the same problem. Please merge this pull request.

[artherd42]

I have the same problem. Please merge this pull request.

[EdJ]

Agreed, I'm also having rsync issues, so merging this in would be great.

[tknerr]

From my experience there are two things you need to take care of in order to make it work on Windows:

1. the rsync executable you have on windows is most likely cygwin-based (at least that's the only one which is compatible with the unix version I know of), thus expects the /cygdrive/... style pathnames. You mentioned cwrsync, personally I simply extracted rsync.exe and ssh.exe from the cygwin packages.
2. one the path is corrected, you will run into an issue where the permissions are messed up and need to be set explicitly via --chmod=ugo=rwX

Both mccloud and knife-solo solve this issue (synced folders via rsync) in the same way and it has proven to work on windows:

• see mccloud PR #30, specifically 56fc78eb
• see knife-solo PR #91, specifically 21def85d

edit: corrected link

[databus23]

I have no special love for cwrsync. It comes as an installer and currently if you don't have cygwin installed its one of the easier ways to get it.
Obviously the best solution would be to have the vagrant installer ship the necessary files for rsync support on windows.
Your 2nd remark is interesting, I didn't run into those problems yet. I will look into it and update my pull request accordingly. Thanks!

In general I think rsync folder sync should be moved out of here and maintained somewhere central, probably as vagrant plugin or even as part of vagrant core. Looking at the other cloud providers (rackspace, digital ocean) this code was just copied and would be nice to fix them all at once.

@mitchellh Any thoughts on that and/or vendoring rsync in the vagrant windows installer?

[tknerr]

@databus23 do you need the --chmod ugo=rwX fix as well with cwrsync?

I'm just wondering... personally I prefer the rsync.exe from the cygwin package as it's closer to the original and there's no need to install a GUI application. Oh wait, and it's free :-)

[tknerr]

@databus23 fully agree, most providers will probably implement shared folders via rsync so it should be implemented once and for all in a more central place

👍 for vendoring the rsync and ssh executables

[tralamazza]

Thanks @databus23