Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pipenv #52

Merged
merged 7 commits into from
Feb 14, 2020
Merged

remove pipenv #52

merged 7 commits into from
Feb 14, 2020

Conversation

Josh-Joseph
Copy link
Collaborator

@Josh-Joseph Josh-Joseph commented Feb 14, 2020

To fix current issues with pipenv #19 I've decided to simply remove its use. This is partially due to a bug that has popped up in machine provisioning and partially due to its continued development/support being in question.

image (4)

Since packages are installed on clean VMs each time which are meant to be single use there is no need for a virtual environment. If a user wants to install it locally we'll leave it up to them to use a virtual environment like virtualenv.

@Josh-Joseph Josh-Joseph added the high priority Do these first label Feb 14, 2020
@Josh-Joseph Josh-Joseph added this to the V1.0 milestone Feb 14, 2020
@Josh-Joseph Josh-Joseph self-assigned this Feb 14, 2020
…ed message larger than max error by logging to file
@Josh-Joseph Josh-Joseph requested a review from rak5216 February 14, 2020 03:09
@rak5216 rak5216 merged commit 784a6e7 into master Feb 14, 2020
@rak5216 rak5216 deleted the jj/remove-pipenv branch February 14, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Do these first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants