Cache intermediate values for Edwards addition #1808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new "cached" point type, which holds the computed values of
(x-y)/2
and(x+y)/2
. Addition is then split into the "prep" function to create a cached point, and the "readdition" function to add a point to a cached point. This proves that the combinationm1readd(P, m1prep(Q))
is equivalent to the straightforward add functionm1add(P,Q)
.This file reuses some of the definitions, proofs, etc. from Basic.v, but for annoying Context reasons some of them had to be copied into this file. There's probably a way to share or reuse them, but it didn't seem worth blocking this change on.
This also doesn't prove
Proper_cached_to_twisted
, which we might want down the line. My straightforward attempt at copyingProper_to_twisted
hit a snag, and nothing in this file actually needed to use it, so I left that out.