-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treesitter Parsing (again) #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treywood
commented
Aug 27, 2024
@@ -15,7 +15,7 @@ M.get_contents = function() | |||
end | |||
if req.body ~= nil then | |||
table.insert(contents, "") | |||
local body_as_table = vim.split(req.body, "\r\n") | |||
local body_as_table = vim.split(req.body, "\r?\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text as parsed by tree-sitter doesn't include carriage returns. i tested this change with the tree-sitter option disabled as well
treywood
force-pushed
the
fix-treesitter-bugs
branch
from
August 29, 2024 17:15
e08b18b
to
f83e95b
Compare
Thanks for your hard work ❤️ 💪 |
gorillamoe
approved these changes
Aug 30, 2024
I'm getting errors on startup occasionally, saying no http ts parser avail.
|
I think this is fixed in 6c4ab0c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #181
run_all
work with treesitterwhat doesn't work (yet):
>>
and>>!
operators aren't part of the http grammar. I opened a pull request to add this to the grammar, and have it implemented in my kulala fork in a separate branch