feat: add TextChunk as possible content type for Assistant message#57
Closed
gcalmettes wants to merge 1 commit intomistralai:mainfrom
Closed
feat: add TextChunk as possible content type for Assistant message#57gcalmettes wants to merge 1 commit intomistralai:mainfrom
gcalmettes wants to merge 1 commit intomistralai:mainfrom
Conversation
Author
|
@jean-malo @patrickvonplaten any chance of this PR to be reviewed on your side ? This still causes some incompatiblity when querying mistral with the openAI client (since on their side textChunks are also valid for assistant messages, like for the other roles) Thanks ! |
Author
|
related: vllm-project/vllm#12859 |
Contributor
|
Done in another PR ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
AssistantMessageclass only acceptsstras type. It is the only role only accepting nothing else thanstr(orNone) as content.This means that payload generated when using the Mistral tokenizer via external systems (e.g. vllm) also accepting
TextChunkas content for the Assistant message, will break:This MR adds
TextChunkas possible content type for theAssistantMessageclass.