Add android-arm64 bindings for swc #9540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #9540 +/- ##
========================================
Coverage 22.57% 22.57%
========================================
Files 731 731
Lines 68099 68099
Branches 2212 2212
========================================
Hits 15375 15375
Misses 52724 52724 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
swcの採用が撤回されたのでdraft化 |
|
swcは使わなそうなので、また使うことになったら出します |
This was referenced Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
swcは複数プラットフォーム向けにプレビルドバイナリを提供しているが、swc側のpackage.jsonには、用意されているプラットフォームの全てが含まれているわけではなく、Androidにおいては手動で追加が必要。
backendのoptionalDependenciesに
@swc/core-android-arm64を追加する。Why
backendのビルド時に
Bindings not foundとエラーが出て実行できないため。補足
もともとはdevDependenciesなのにoptionalDependenciesに入れても大丈夫なのかどうか...