Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 画面を閉じる直前にAudioContextを閉じるように #15080

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

書いてあるとおり

Why

Chrome 系 on macOS で AudioContext 開きっぱなしの状態でタブ閉じると他のタブのオーディオが壊れる問題にぶち当たる(らしい)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 19.32%. Comparing base (e8bf628) to head (c2af18b).

Files with missing lines Patch % Lines
packages/frontend/src/scripts/sound.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15080       +/-   ##
============================================
- Coverage    39.96%   19.32%   -20.64%     
============================================
  Files         1563      728      -835     
  Lines       197752   103812    -93940     
  Branches      3634      991     -2643     
============================================
- Hits         79031    20066    -58965     
+ Misses      118116    83192    -34924     
+ Partials       605      554       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Dec 10, 2024

chromeのバグということを明記した方が良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants