Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 2024.8.0 #14391

Merged
merged 60 commits into from
Aug 18, 2024
Merged

Release: 2024.8.0 #14391

merged 60 commits into from
Aug 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 11, 2024

General

  • Enhance: モデレーターはすべてのユーザーのフォロー・フォロワーの一覧を見られるように
  • Enhance: アカウントの削除のモデレーションログを残すように
  • Enhance: 不適切なページ、ギャラリー、Playを管理者権限で削除できるように
  • Fix: リモートユーザのフォロー・フォロワーの一覧が非公開設定の場合も表示できてしまう問題を修正

Client

  • Enhance: 「自分のPlay」ページにおいてPlayが非公開かどうかが一目でわかるように
  • Enhance: 不適切なページ、ギャラリー、Playを通報できるように
  • Fix: Play編集時に公開範囲が「パブリック」にリセットされる問題を修正
  • Fix: ページ遷移に失敗することがある問題を修正
  • Fix: iOSでユーザー名などがリンクとして誤検知される現象を抑制
  • Fix: mCaptchaを使用していてもbotプロテクションに関する警告が消えないのを修正
  • Fix: ユーザーのモデレーションページにおいてユーザー名にドットが入っているとシステムアカウントとして表示されてしまう問題を修正
  • Fix: 特定の条件下でノートの削除ボタンが出ないのを修正

Server

github-actions bot and others added 19 commits July 31, 2024 11:20
… / feat: moderators can see following/followers of all users (#14375)

* fix(backend): check visibility of following/followers of remote users

Resolves #13362.

* test(backend): add tests for visibility of following/followers of remote users

* docs(changelog): update CHANGELOG.md

* feat: moderators can see following/followers of all users

* docs(changelog): update CHANGELOG.md

* refactor(backend): minor refactoring

`createPerson`と`if`の条件を統一するとともに、異常系の
処理をearly returnに追い出すための変更。

* feat(backend): moderators can see following/followers count of all users

As per #14375 (comment).
* refactor: add and use isJsonObject

* fix: readNotification message without body is not working

* docs(changelog): WSの`readAllNotifications` メッセージが `body` を持たない場合に動作しない問題

* Update CHANGELOG.md

Co-authored-by: Sayamame-beans <[email protected]>

---------

Co-authored-by: Sayamame-beans <[email protected]>
* fix(backend): missing `visibility` param in packing flash

* fix(frontend): use `visibility` value got from API

* enhance(frontend): change preview appearance of private Play

* Update CHANGELOG.md
* fix(frontend): ページ遷移に失敗することがある問題を修正 (bump vue version)

* Update Changelog

---------

Co-authored-by: syuilo <[email protected]>
* fix(frontend): iosでの自動リンク化を抑制

* Update Changelog

* typo

* typo

* Update CHANGELOG.md
* fix(frontend): mCaptchaを使用していてもbotプロテクションに関する警告が消えないのを修正

* Update Changelog

* refactor
* fix: pass current user into `InstanceEntityService.packMany`

(cherry picked from commit 858ba18)

* Update Changelog

* origin

* Update Changelog

---------

Co-authored-by: Hazel K <[email protected]>
* fix(backend): getApTypeでエラーを投げないように

* Update Changelog

* Update Changelog

* Update type.ts

* add comment
* fix(chart): ダイレクト投稿をユーザーごとのチャートから除外 (MisskeyIO#679)

(cherry picked from commit 3db41c2)

* Update Changelog

---------

Co-authored-by: Yuuki <[email protected]>
Co-authored-by: syuilo <[email protected]>
* New translations ja-jp.yml (Thai)

* New translations ja-jp.yml (Chinese Simplified)

* New translations ja-jp.yml (Thai)

* New translations ja-jp.yml (Thai)

* New translations ja-jp.yml (Chinese Traditional)

* New translations ja-jp.yml (Thai)

* New translations ja-jp.yml (Thai)

* New translations ja-jp.yml (Thai)

* New translations ja-jp.yml (Japanese, Kansai)

* New translations ja-jp.yml (Japanese, Kansai)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (French)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (English)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (English)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Portuguese)
@kakkokari-gtyih kakkokari-gtyih added this to the v2024.8.0 milestone Aug 11, 2024
Copy link
Contributor Author

github-actions bot commented Aug 11, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -1,7 +1,7 @@
 {
   "openapi": "3.1.0",
   "info": {
-    "version": "2024.7.0",
+    "version": "2024.8.0-rc.5",
     "title": "Misskey API"
   },
   "externalDocs": {
@@ -38157,6 +38157,15 @@
                       }
                     }
                   },
+                  "ACCESS_DENIED": {
+                    "value": {
+                      "error": {
+                        "message": "Access denied.",
+                        "code": "ACCESS_DENIED",
+                        "id": "c86e09de-1c48-43ac-a435-1c7e42ed4496"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {
@@ -79948,6 +79957,13 @@
           "script": {
             "type": "string"
           },
+          "visibility": {
+            "type": "string",
+            "enum": [
+              "private",
+              "public"
+            ]
+          },
           "likedCount": {
             "type": [
               "number",
@@ -79967,6 +79983,7 @@
           "title",
           "summary",
           "script",
+          "visibility",
           "likedCount"
         ]
       },

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 25.46523% with 761 lines in your changes missing coverage. Please review.

Project coverage is 39.86%. Comparing base (1a521a4) to head (f4f55ef).
Report is 2 commits behind head on master.

Files Patch % Lines
packages/frontend/src/pages/page.vue 0.00% 70 Missing ⚠️
packages/backend/src/core/UserSuspendService.ts 21.05% 60 Missing ⚠️
packages/frontend/src/scripts/focus-trap.ts 3.33% 58 Missing ⚠️
...tend/src/components/MkFlashPreview.stories.impl.ts 0.00% 52 Missing and 1 partial ⚠️
packages/frontend/src/pages/gallery/post.vue 0.00% 51 Missing ⚠️
packages/frontend/src/pages/flash/flash.vue 0.00% 50 Missing ⚠️
packages/backend/src/core/DeleteAccountService.ts 21.15% 41 Missing ⚠️
packages/frontend/src/components/MkRolePreview.vue 0.00% 40 Missing ⚠️
...s/backend/src/core/activitypub/ApRequestService.ts 4.16% 23 Missing ⚠️
packages/backend/src/core/ReversiService.ts 25.00% 21 Missing ⚠️
... and 44 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14391      +/-   ##
==========================================
- Coverage   39.91%   39.86%   -0.05%     
==========================================
  Files        1544     1547       +3     
  Lines      190356   190953     +597     
  Branches     3539     2702     -837     
==========================================
+ Hits        75981    76125     +144     
- Misses     113784   114266     +482     
+ Partials      591      562      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* New translations ja-jp.yml (Chinese Traditional)

* New translations ja-jp.yml (Chinese Simplified)

* New translations ja-jp.yml (Chinese Simplified)
@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

アカウント作成時にダイアログ形式のお知らせがあるとチュートリアルダイアログと競合して操作がままならなくなってる(いままではお知らせの方が優先されて普通に閉じれた)

Copy link
Member

@syuilo syuilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#14391 (comment)
これクリティカルなので直したい

@samunohito
Copy link
Member

操作がままならなくなってる

他のボタンとか一切押せない感じですかね?

@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

操作がままならなくなってる

他のボタンとか一切押せない感じですかね?

モーダル背後のチュートリアルダイアログは操作できるけど、ブラーかかっている & お知らせダイアログで視界不良で事実上操作不能

warriordog and others added 2 commits August 18, 2024 13:34
* encapsulate `MemoryKVCache<T>`

* remove infinity caches

* encapsulate other caches

* add missing awaits to internally synchronize caches

* implement pull-through caching

* tune cache lifetimes

* optimize cache GC by stopping early

* summarize changes in CHANGELOG.md

* Fix timeout comments

Co-authored-by: かっこかり <[email protected]>

* add comments about awaiting the redis write

---------

Co-authored-by: かっこかり <[email protected]>
@kakkokari-gtyih
Copy link
Contributor

focustrapが実際の表示順に関係なく呼ばれた順にfocustrapしているっぽいので改修中

@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

同時に二つ以上のモーダルが開かないように改修もしたい

@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

バグ関係なく普通にUXとしてアレ

@samunohito
Copy link
Member

samunohito commented Aug 18, 2024

同時に二つ以上のモーダルが開かないように改修もしたい

多重に開けることを期待して実装されてるところもありそうなので、8.0より後でやりたいかも

@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

モーダルが2つ以上開く問題を修正すれば
#14391 (comment)
の改修が不要になるかも

@kakkokari-gtyih
Copy link
Contributor

とりあえず実際の表示順(z-indexが高い順)でfocustrapがかかるように改修した
#14431

Copy link
Member

@syuilo syuilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOSASOU

@kakkokari-gtyih
Copy link
Contributor

#14432

@kakkokari-gtyih
Copy link
Contributor

#14432

マージしたのでリリース可

@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

ぽちっとなするぞ

@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

ぽちっとな

@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

ぽちっと以外全部な

@syuilo
Copy link
Member

syuilo commented Aug 18, 2024

ぽちっとな

@misskey-release-bot misskey-release-bot bot merged commit 882c8b9 into master Aug 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.