-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(frontend): ブラウザのコンテキストメニューを使用できるように #14076
Merged
+45
−0
Merged
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
33f566c
enhance(frontend): ブラウザのコンテキストメニューを使用できるように
kakkokari-gtyih 28a5b07
Update Changelog
kakkokari-gtyih 3c01feb
Merge branch 'develop' into enh-7087
kakkokari-gtyih 70a0418
shiftにした
kakkokari-gtyih 416e3c8
Merge branch 'enh-7087' of https://github.com/kakkokari-gtyih/misskey…
kakkokari-gtyih fea0b01
Merge branch 'develop' into enh-7087
kakkokari-gtyih 1f9d8e0
Merge branch 'develop' into enh-7087
kakkokari-gtyih ec2baae
Merge branch 'develop' into enh-7087
kakkokari-gtyih ca44e3d
Merge branch 'develop' into enh-7087
kakkokari-gtyih ae7fdb1
Merge branch 'develop' into enh-7087
kakkokari-gtyih 86328d8
Merge branch 'develop' into enh-7087
tamaina be21fc4
Merge branch 'develop' into enh-7087
kakkokari-gtyih 1fc124b
change keys
kakkokari-gtyih 7a8d40e
fix
kakkokari-gtyih acf0cc3
fix
kakkokari-gtyih 662ad82
fix
kakkokari-gtyih 2fa9b91
update translation keys
kakkokari-gtyih b9233cb
Merge branch 'develop' into enh-7087
kakkokari-gtyih 0846537
Merge branch 'develop' into enh-7087
kakkokari-gtyih 4f93bb0
Merge branch 'develop' into enh-7087
kakkokari-gtyih File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
で良さそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「アプリケーション」だと何のことか分からなくならない?(ブラウザもアプリケーションなので)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
利用者は今使っているものが「Misskey」であると認識していない可能性があるわね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
うーむ
かといってアプリケーションは混同しそうだしサーバー名書いてもかえってなんのことかわかりにくそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
それはそれで書くほどのこと無い気がしたので最初の提案通りで(わかりにくい旨の指摘が出たら再検討でよいかも)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
個人的にはWebアプリをアプリケーションというのはちょっと違う気が…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(インストールが必要な一般の"アプリ"やソフトウェアの意味に感じる)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「標準メニュー」と「Misskey独自メニュー」とか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
個人的には良さそうなのですが
があり…(個人的にはそこまで気にしなくても良いのではないかとも思ってしまいますが)