Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: say bye to the weird groupBy friends #13975

Merged
merged 4 commits into from
Jun 22, 2024
Merged

refactor: say bye to the weird groupBy friends #13975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6394ce3
refactor(frontend): say bye to the weird groupBy friends
KisaragiEffective Jun 13, 2024
50fe422
refactor(backend): say bye to the weird groupBy friends
KisaragiEffective Jun 13, 2024
5a5d2ef
Merge branch 'develop' into refactor/issue/5529
KisaragiEffective Jun 15, 2024
3aa906f
Merge branch 'develop' into refactor/issue/5529
KisaragiEffective Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions packages/backend/src/misc/prelude/array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,44 +65,6 @@ export function maximum(xs: number[]): number {
return Math.max(...xs);
}

/**
* Splits an array based on the equivalence relation.
* The concatenation of the result is equal to the argument.
*/
export function groupBy<T>(f: EndoRelation<T>, xs: T[]): T[][] {
const groups = [] as T[][];
for (const x of xs) {
const lastGroup = groups.at(-1);
if (lastGroup !== undefined && f(lastGroup[0], x)) {
lastGroup.push(x);
} else {
groups.push([x]);
}
}
return groups;
}

/**
* Splits an array based on the equivalence relation induced by the function.
* The concatenation of the result is equal to the argument.
*/
export function groupOn<T, S>(f: (x: T) => S, xs: T[]): T[][] {
return groupBy((a, b) => f(a) === f(b), xs);
}

export function groupByX<T>(collections: T[], keySelector: (x: T) => string) {
return collections.reduce((obj: Record<string, T[]>, item: T) => {
const key = keySelector(item);
if (!Object.prototype.hasOwnProperty.call(obj, key)) {
obj[key] = [];
}

obj[key].push(item);

return obj;
}, {});
}

/**
* Compare two arrays by lexicographical order
*/
Expand Down
38 changes: 0 additions & 38 deletions packages/frontend/src/scripts/array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,44 +77,6 @@ export function maximum(xs: number[]): number {
return Math.max(...xs);
}

/**
* Splits an array based on the equivalence relation.
* The concatenation of the result is equal to the argument.
*/
export function groupBy<T>(f: EndoRelation<T>, xs: T[]): T[][] {
const groups = [] as T[][];
for (const x of xs) {
const lastGroup = groups.at(-1);
if (lastGroup !== undefined && f(lastGroup[0], x)) {
lastGroup.push(x);
} else {
groups.push([x]);
}
}
return groups;
}

/**
* Splits an array based on the equivalence relation induced by the function.
* The concatenation of the result is equal to the argument.
*/
export function groupOn<T, S>(f: (x: T) => S, xs: T[]): T[][] {
return groupBy((a, b) => f(a) === f(b), xs);
}

export function groupByX<T>(collections: T[], keySelector: (x: T) => string) {
return collections.reduce((obj: Record<string, T[]>, item: T) => {
const key = keySelector(item);
if (typeof obj[key] === 'undefined') {
obj[key] = [];
}

obj[key].push(item);

return obj;
}, {});
}

/**
* Compare two arrays by lexicographical order
*/
Expand Down
Loading