Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 画面表示後最初の音声再生が爆音になることがある問題を修正 #13379

Merged
merged 5 commits into from
Feb 20, 2024
Merged

fix(frontend): 画面表示後最初の音声再生が爆音になることがある問題を修正 #13379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0c5216
fix(frontend): 画面表示後最初の音声再生が爆音になることがある問題を修正
zyoshoka Feb 18, 2024
37481fa
Update CHANGELOG.md
zyoshoka Feb 18, 2024
d364f0d
Merge branch 'develop' into fix-sfx-produces-bakuon
zyoshoka Feb 19, 2024
985d39b
Update CHANGELOG.md
zyoshoka Feb 19, 2024
2d77ccb
Merge branch 'develop' into fix-sfx-produces-bakuon
zyoshoka Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
- Fix: syuilo/misskeyの時代からあるインスタンスが改変されたバージョンであると誤認識される問題
- Fix: MFMのオートコンプリートが出るべき状況で出ないことがある問題を修正
- Fix: チャートのラベルが消えている問題を修正
- Fix: 画面表示後最初の音声再生が爆音になることがある問題を修正

### Server
- Fix: nodeinfoにenableMcaptchaとenableTurnstileが無いのを修正
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/src/scripts/sound.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export async function loadAudio(url: string, options?: { useCache?: boolean; })
*/
export function playMisskeySfx(operationType: OperationType) {
const sound = defaultStore.state[`sound_${operationType}`];
if (sound.type == null || !canPlay) return;
if (sound.type == null || !canPlay || !navigator.userActivation.hasBeenActive) return;

canPlay = false;
playMisskeySfxFile(sound).finally(() => {
Expand Down
Loading