-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
タイムラインの「リノートを表示」のトグルスイッチが反応しない問題を直す #12577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #12578 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12577 +/- ##
===========================================
- Coverage 78.79% 78.54% -0.25%
===========================================
Files 956 183 -773
Lines 103997 24121 -79876
Branches 8333 497 -7836
===========================================
- Hits 81941 18946 -62995
+ Misses 22056 5175 -16881 ☔ View full report in Codecov by Sentry. |
これは具体的にどこかしら? |
この部分です
|
PR更新しました |
5 tasks
🙏🙏 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* [frontend] Fix renote toggle switch * Fix MkMenu rather than usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
「リノートを表示」トグルスイッチの disabled 属性に false を指定する
Why
トグルスイッチの disabled に boolean の値を指定しないと、value属性を参照しようとするため。
Additional info (optional)
Checklist