Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

タイムラインの「リノートを表示」のトグルスイッチが反応しない問題を直す #12577

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

yuriha-chan
Copy link
Contributor

What

「リノートを表示」トグルスイッチの disabled 属性に false を指定する

Why

トグルスイッチの disabled に boolean の値を指定しないと、value属性を参照しようとするため。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 4, 2023
@yuriha-chan
Copy link
Contributor Author

Fixes #12578

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (920e521) 78.79% compared to head (29b729e) 78.54%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12577      +/-   ##
===========================================
- Coverage    78.79%   78.54%   -0.25%     
===========================================
  Files          956      183     -773     
  Lines       103997    24121   -79876     
  Branches      8333      497    -7836     
===========================================
- Hits         81941    18946   -62995     
+ Misses       22056     5175   -16881     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Dec 5, 2023

value属性を参照しようとする

これは具体的にどこかしら?
そこを直した方が良さそう

@yuriha-chan
Copy link
Contributor Author

この部分です

if (typeof item.disabled === 'boolean' ? item.disabled : item.disabled.value) return;

@yuriha-chan
Copy link
Contributor Author

PR更新しました

@syuilo syuilo merged commit ad60e43 into misskey-dev:develop Dec 6, 2023
14 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 6, 2023

🙏🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants