Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 自分へのリプライのみ走査するように #12570

Merged

Conversation

anatawa12
Copy link
Member

What

LTLへ自分へのリプライを追加する際にすべてのリプライを走査していましたが、fanoutTimelineに種別を追加することで自分へのリプライのみを走査するようにしました

Why

#12565 を実装してる最中、localTimelinelocalTimelineWithRepliesがあまり使い分けられてない状態になってたので気になったためです。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (18109fc) 78.76% compared to head (c6fef63) 78.80%.

Files Patch % Lines
...d/src/server/api/endpoints/notes/local-timeline.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12570      +/-   ##
===========================================
+ Coverage    78.76%   78.80%   +0.03%     
===========================================
  Files          955      957       +2     
  Lines       103817   104014     +197     
  Branches      8334     8337       +3     
===========================================
+ Hits         81770    81966     +196     
- Misses       22047    22048       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit bb38e62 into misskey-dev:develop Dec 4, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 4, 2023

👍

@anatawa12 anatawa12 deleted the add-local-timeline-for-replies-to-me branch December 4, 2023 12:47
@anatawa12
Copy link
Member Author

STLでこれを使い忘れてるせいで自分へのリプライがSTLで表示されないバグが発覚した

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants