Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ログアウト状態でのノートメニュー内の詳細ボタンの表示をログイン状態と同じに #11896

Conversation

zyoshoka
Copy link
Contributor

What

ログアウト状態でのノートメニュー内の詳細ボタンの表示を、ログイン状態のそれと同じにしました

Why

Fix: #11895

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 24, 2023
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (646a8d1) 78.79% compared to head (7ae71f5) 78.79%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11896      +/-   ##
===========================================
- Coverage    78.79%   78.79%   -0.01%     
===========================================
  Files          928      928              
  Lines        98579    98579              
  Branches      7849     7845       -4     
===========================================
- Hits         77678    77675       -3     
- Misses       20901    20904       +3     
Files Changed Coverage Δ
packages/frontend/src/scripts/get-note-menu.ts 6.19% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit dcaea66 into misskey-dev:develop Sep 25, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 25, 2023

🙏🏻

@zyoshoka zyoshoka deleted the fix-opendetail-button-display-in-logged-out branch May 15, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
2 participants