Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mk:apiが失敗時エラー型の値を返すように (#2) #11843

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

FineArchs
Copy link
Contributor

@FineArchs FineArchs commented Sep 18, 2023

What

AiScriptのMk:api関数が失敗した時、エラー型の値(AiScript 0.16.0で追加)を返すようにします。

Why

#11839

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (aa80cfd) 78.88% compared to head (4482feb) 78.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11843      +/-   ##
===========================================
+ Coverage    78.88%   78.89%   +0.01%     
===========================================
  Files          924      175     -749     
  Lines        97523    22856   -74667     
  Branches      7748      511    -7237     
===========================================
- Hits         76927    18033   -58894     
+ Misses       20596     4823   -15773     

see 749 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 44985ae into misskey-dev:develop Sep 18, 2023
@syuilo
Copy link
Member

syuilo commented Sep 18, 2023

🙏

@FineArchs FineArchs deleted the api_err2 branch September 24, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants