Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PhotoSwipeによるクライアントのメモリリークの解消 #11395

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

kabo2468
Copy link
Contributor

What

Unmounted時にPhotoSwipeを破棄するようにした

Why

クライアントのメモリーのスナップショットを取ってみたところ、PhotoSwipeによる大量のDetached Elementsがありました
そこでUnmount時に破棄したところ、改善がありました
ioのローカルなど大量にメディアが流れる、かつ長時間クライアントを放置する場合、より多くのリークを減らすことができます

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 26, 2023
@github-actions github-actions bot requested review from acid-chicken and tamaina July 26, 2023 17:57
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #11395 (63152eb) into develop (090253c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11395      +/-   ##
===========================================
- Coverage    77.68%   77.66%   -0.02%     
===========================================
  Files          919      918       -1     
  Lines        92696    92645      -51     
  Branches      7749     7748       -1     
===========================================
- Hits         72008    71954      -54     
- Misses       20688    20691       +3     
Files Changed Coverage Δ
packages/frontend/src/components/MkMediaList.vue 94.72% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

@syuilo syuilo merged commit 71b016b into misskey-dev:develop Jul 26, 2023
@syuilo
Copy link
Member

syuilo commented Jul 26, 2023

👍👍👍

@kabo2468 kabo2468 deleted the destroy-pswp branch July 26, 2023 21:45
@tai-cha tai-cha mentioned this pull request Jul 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants