Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL取得方法を関数に変更 #11392 #11393

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

setaria430
Copy link
Contributor

What

現在表示中のURLを取得する方法を関数呼び出しに変更した

Why

以前、表示中のURLを取得するために環境変数を追加したが、目的の画面で一度ユーザが再読み込みしなければならず、使い勝手が良くなかったため
関数呼び出しに変更することで、aiscript側が任意のタイミングでURLを取得できる

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 26, 2023
@github-actions github-actions bot requested review from EbiseLutica and syuilo July 26, 2023 16:00
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #11393 (824bf76) into develop (cf3ac3c) will decrease coverage by 0.05%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11393      +/-   ##
===========================================
- Coverage    77.70%   77.66%   -0.05%     
===========================================
  Files          920      918       -2     
  Lines        92795    92636     -159     
  Branches      7749     7748       -1     
===========================================
- Hits         72109    71945     -164     
- Misses       20686    20691       +5     

see 4 files with indirect coverage changes

@syuilo syuilo merged commit 78b502b into misskey-dev:develop Jul 27, 2023
@syuilo
Copy link
Member

syuilo commented Jul 27, 2023

👍🏻

@tai-cha tai-cha mentioned this pull request Jul 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants