Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): workaround storybook issue #11334

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(frontend): workaround storybook issue #11334

merged 1 commit into from
Jul 20, 2023

Conversation

saschanaz
Copy link
Member

What

#11267 えの対応

Why

テスト失敗を防止(理由はさっぱり分かりませんが)

Additional info (optional)

Chromaticではなくローカルでもconsole.warnが見えましたので、なにか問題があるのは確実です

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook (N/A)
  • (If needed) Update CHANGELOG.md (N/A)
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 20, 2023
@github-actions github-actions bot requested review from syuilo and tamaina July 20, 2023 21:52
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #11334 (ee2b3ec) into develop (509e3f9) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11334      +/-   ##
===========================================
+ Coverage    77.68%   77.74%   +0.06%     
===========================================
  Files          917      172     -745     
  Lines        92563    21589   -70974     
  Branches      7748      498    -7250     
===========================================
- Hits         71908    16785   -55123     
+ Misses       20655     4804   -15851     

see 745 files with indirect coverage changes

@syuilo syuilo merged commit df2b61f into develop Jul 20, 2023
@syuilo syuilo deleted the storybook-lock branch July 20, 2023 22:11
@syuilo
Copy link
Member

syuilo commented Jul 20, 2023

🙏🙏🙏

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants