Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix cat ears are awkward on reply modal #11309

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

RieLCho
Copy link
Contributor

@RieLCho RieLCho commented Jul 18, 2023

What

This will fix #11279, shows cat ears on reply modal.

but this is the very easiest (might be naive) way to fix this issue. If hurting css is not enough for misskey maintainers, i will try to find another way.

Why

misskey's cat ears are so cute. cute enough not to hidden by modal header.

Additional info (optional)

스크린샷 2023-07-18 오후 3 03 43 스크린샷 2023-07-18 오후 3 04 06

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 18, 2023
@github-actions github-actions bot requested review from acid-chicken and tamaina July 18, 2023 06:08
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #11309 (4dcd037) into develop (e410b8a) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11309      +/-   ##
===========================================
- Coverage    77.74%   77.69%   -0.05%     
===========================================
  Files          918      916       -2     
  Lines        92699    92541     -158     
  Branches      7746     7741       -5     
===========================================
- Hits         72068    71903     -165     
- Misses       20631    20638       +7     
Impacted Files Coverage Δ
packages/frontend/src/components/MkPostForm.vue 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@RieLCho RieLCho changed the title fix(frontend): #11279 adjusted margin & padding Resolves #11279 Jul 18, 2023
@tamaina tamaina changed the title Resolves #11279 Fix(frontend): Fix cat ears are awkward on reply modal Jul 19, 2023
@tamaina tamaina changed the title Fix(frontend): Fix cat ears are awkward on reply modal fix(frontend): Fix cat ears are awkward on reply modal Jul 19, 2023
@tamaina tamaina merged commit 5280a5e into misskey-dev:develop Jul 19, 2023
@tamaina
Copy link
Contributor

tamaina commented Jul 19, 2023

🙏

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
…1309)

* fix(frontend): misskey-dev#11279 adjusted margin & padding

* Revert "fix(frontend): misskey-dev#11279 adjusted margin & padding"

This reverts commit e82a2d4.

* fix(frontend): adjusted margin & padding
@acid-chicken
Copy link
Member

これ非リプライ投稿画面でスタイル崩れ起こしてない?

@RieLCho
Copy link
Contributor Author

RieLCho commented Jul 23, 2023

image

image

やっば

@acid-chicken acid-chicken mentioned this pull request Jul 26, 2023
syuilo added a commit that referenced this pull request Jul 26, 2023
@tai-cha tai-cha mentioned this pull request Jul 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cat ears seems awkward on reply modal.
4 participants