-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): Fix cat ears are awkward on reply modal #11309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #11309 +/- ##
===========================================
- Coverage 77.74% 77.69% -0.05%
===========================================
Files 918 916 -2
Lines 92699 92541 -158
Branches 7746 7741 -5
===========================================
- Hits 72068 71903 -165
- Misses 20631 20638 +7
|
RieLCho
changed the title
fix(frontend): #11279 adjusted margin & padding
Resolves #11279
Jul 18, 2023
saschanaz
approved these changes
Jul 18, 2023
tamaina
changed the title
Resolves #11279
Fix(frontend): Fix cat ears are awkward on reply modal
Jul 19, 2023
tamaina
changed the title
Fix(frontend): Fix cat ears are awkward on reply modal
fix(frontend): Fix cat ears are awkward on reply modal
Jul 19, 2023
🙏 |
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
…1309) * fix(frontend): misskey-dev#11279 adjusted margin & padding * Revert "fix(frontend): misskey-dev#11279 adjusted margin & padding" This reverts commit e82a2d4. * fix(frontend): adjusted margin & padding
これ非リプライ投稿画面でスタイル崩れ起こしてない? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This will fix #11279, shows cat ears on reply modal.
but this is the very easiest (might be naive) way to fix this issue. If hurting css is not enough for misskey maintainers, i will try to find another way.
Why
misskey's cat ears are so cute. cute enough not to hidden by modal header.
Additional info (optional)
Checklist