Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): use slacc instead of unzipper #10780

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix(backend): use slacc instead of unzipper #10780

merged 2 commits into from
Jul 20, 2023

Conversation

acid-chicken
Copy link
Member

@acid-chicken acid-chicken commented May 6, 2023

Fix #10778

What

unzipper をやめる

Additional info (optional)

misskey-dev/slacc 側ではテストしたけど misskey-dev/misskey 側では未テスト

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot requested a review from tamaina May 6, 2023 13:18
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #10780 (b6cd38e) into develop (51b02ef) will decrease coverage by 0.16%.
The diff coverage is 9.09%.

@@             Coverage Diff             @@
##           develop   #10780      +/-   ##
===========================================
- Coverage    77.84%   77.68%   -0.16%     
===========================================
  Files          919      917       -2     
  Lines        92756    92601     -155     
  Branches      7773     7745      -28     
===========================================
- Hits         72205    71937     -268     
- Misses       20551    20664     +113     
Impacted Files Coverage Δ
...e/processors/ImportCustomEmojisProcessorService.ts 38.09% <9.09%> (-1.25%) ⬇️

... and 19 files with indirect coverage changes

@acid-chicken acid-chicken requested a review from syuilo May 11, 2023 13:12
@acid-chicken
Copy link
Member Author

レビューを待っている間に情勢が変化したので close

@tamaina
Copy link
Contributor

tamaina commented Jul 20, 2023

とりあえずreopenした

@github-actions github-actions bot requested a review from EbiseLutica July 20, 2023 04:29
@tamaina
Copy link
Contributor

tamaina commented Jul 20, 2023

こっちでもテスト必要だなぁ

@tamaina tamaina changed the title perf: use slacc instead of unzipper fix,perf(backend): use slacc instead of unzipper Jul 20, 2023
@tamaina
Copy link
Contributor

tamaina commented Jul 20, 2023

ローカルではインポートできた

@acid-chicken
Copy link
Member Author

@tamaina tamaina changed the title perf: use slacc instead of unzipper fix,perf(backend): use slacc instead of unzipper Jul 20, 2023

conventional commit 形式でそのフォーマットは変では……

@acid-chicken acid-chicken changed the title fix,perf(backend): use slacc instead of unzipper fix(backend): use slacc instead of unzipper Jul 20, 2023
@tamaina
Copy link
Contributor

tamaina commented Jul 20, 2023

conventional commit 形式で

Misskeyでconventional commitが仕様として採用された記憶や記載がない

@tamaina tamaina merged commit e6fca72 into develop Jul 20, 2023
@tamaina tamaina deleted the slacc/zip branch July 20, 2023 08:00
@tamaina
Copy link
Contributor

tamaina commented Jul 20, 2023

あっ、しかもコミットログが元のやつになってる(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

エクスポートしたカスタム絵文字のzipが大きいと読み込めない
2 participants