Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 登録フォームにおける競合状態を修正 #10267

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

Ry0taK
Copy link
Contributor

@Ry0taK Ry0taK commented Mar 8, 2023

What

  • 登録フォームにおいてユーザー名/メールアドレス入力時のリクエストが同時に走った場合、先に走ったリクエストをキャンセルするように
  • 重複したユーザー名を入力した際のテストを分割

Why

  • 登録フォームにおいてユーザー名/メールアドレスを高速に入力した場合、誤った利用可否が表示される場合があったため
  • 異なる目的のテストがまとまっていると切り分けが難しくなるため

Additional info (optional)

@github-actions github-actions bot added packages/frontend Client side specific issue/PR 🧪Test labels Mar 8, 2023
@Ry0taK Ry0taK marked this pull request as ready for review March 8, 2023 04:52
@github-actions github-actions bot requested review from syuilo and tamaina March 8, 2023 04:53
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #10267 (5dd3e2d) into develop (dd6569a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10267   +/-   ##
========================================
  Coverage    69.31%   69.31%           
========================================
  Files          713      713           
  Lines        65914    65914           
  Branches      5256     5258    +2     
========================================
  Hits         45687    45687           
  Misses       20227    20227           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 116dd09 into misskey-dev:develop Mar 8, 2023
@syuilo
Copy link
Member

syuilo commented Mar 8, 2023

👍🏻

@saschanaz
Copy link
Member

👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

登録時の重複チェックが間違った結果を返すケースがある
3 participants