Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 13.7.2 #10035

Merged
merged 16 commits into from
Feb 23, 2023
Merged

Release: 13.7.2 #10035

merged 16 commits into from
Feb 23, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Feb 23, 2023

What

Why

Additional info (optional)

syuilo and others added 13 commits February 23, 2023 08:23
Windowsだとエラーが出るため
* feat: add optional swc

* fix: windowsで動かない現象を修正

* fix: fix swc path alias

* fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更
* feat: add optional swc

* fix: windowsで動かない現象を修正

* fix: fix swc path alias

* fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更

* feat(server): add @swc/core-android-arm64 to optional

* fix: conflict
@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels Feb 23, 2023
@syuilo syuilo changed the title 13.7.2 Release: 13.7.2 Feb 23, 2023
@syuilo syuilo requested a review from tamaina February 23, 2023 07:44
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #10035 (c328584) into master (8ca2f24) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c328584 differs from pull request most recent head 694f08c. Consider uploading reports for the commit 694f08c to get more accurate results

@@           Coverage Diff           @@
##           master   #10035   +/-   ##
=======================================
  Coverage   24.60%   24.60%           
=======================================
  Files         705      705           
  Lines       65212    65212           
  Branches     2297     2297           
=======================================
+ Hits        16045    16047    +2     
+ Misses      49167    49165    -2     
Impacted Files Coverage Δ
packages/backend/src/misc/secure-rndstr.ts 100.00% <0.00%> (+9.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

CHANGELOGがねぇ

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

192.pngと512.pngってもうちょっと圧縮できないかしら
(グラデーションあるときついか)

tamaina
tamaina previously approved these changes Feb 23, 2023
@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

192.pngと512.pngってもうちょっと圧縮できないかしら (グラデーションあるときついか)

PNGGauntlet通したらそれぞれ26kbと162kbにはなった

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

品質に問題がなければ圧縮の方がいいかも

@syuilo syuilo merged commit 71900e0 into master Feb 23, 2023
strategy:
matrix:
workspace:
- backend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここswとfrontendがないですが🤔🤔🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リリース通るために外したのでしょうか(なんかだめな気がしますが、まあ理解はできます)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontendは性質上型を付けるのが難しい場合が非常に多いので除外してます

AyumuNekozuki added a commit to AyumuNekozuki/misskey that referenced this pull request Feb 27, 2023
* ci: swcにしたためtypecheckは別途実施

* 🎨

* Update package.json

* マイグレーションが失敗することがあるのを修正

* refactor ci

* use tsc for build

Windowsだとエラーが出るため

* feat: swc build in windows (misskey-dev#10032)

* feat: add optional swc

* fix: windowsで動かない現象を修正

* fix: fix swc path alias

* fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更

* use swc

* chore(client): tweak custom emoji size

* enhance: make pwa icon maskable (misskey-dev#10033)

* 🎨

* feat(server): add @swc/core-android-arm64 to optional (misskey-dev#10034)

* feat: add optional swc

* fix: windowsで動かない現象を修正

* fix: fix swc path alias

* fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更

* feat(server): add @swc/core-android-arm64 to optional

* fix: conflict

* Update package.json

* chore(backend): fix indent

* Update CHANGELOG.md

* compress png

---------

Co-authored-by: CaffeinePower <[email protected]>
Co-authored-by: Shogo Sensui <[email protected]>
Co-authored-by: tamaina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants