Rendering improvements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
reviewed
Nov 23, 2023
|
Fabulous! (pun maybe intended) Testing this, things look so much better already. Of course there are still problems when there are multiple translucent blocks behind each other, but even the game struggles with this. Happy to merge and publish this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes 2 rendering improvements. Both are activated by new BlockFlags and don't change anything unless these flags are set on some blocks - making them fully backwards compatible.
semi_transparentflag set are added to a different mesh by the chunk builder. ThegetMeshesfunction returns the transparent meshes last, so that when rendering them in order, the transparent meshes are rendered last. This fixes the issue where solid blocks are not visible behind semi-transparent blocks.self_cullingflag controls weather a block culls faces of itself when placed next itself. For vanilla, ResourceManagers can set this to true for all blocks except leaves.