fix _get_word_ngrams() #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for this. Can you squash these commits into one and add new test instead of modifying existing one please? Also please rebase your branch to current master - I fixed failing tests for Python 3.3. there. Thanks. |
odek53r
force-pushed
the
dev
branch
2 times, most recently
from
0998a15
to
052ef48
Compare
|
done |
miso-belica
approved these changes
Mar 5, 2017
|
Thanks, merged in bc489c6 with some tweaks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I get a wrong tuple, ('test','This'), in the results, when inputting two sentences, 'This is a test' and 'This is a contest', to the _get_word_ngrams(2, sentences). The expected results are ('This','is'), ('is','a'), ('a','test'), ('a','contest').
The image clearly shows debug results when running test_get_word_ngrams() using PyCharm.
The reason to the mistake results is that _get_word_ngrams() concatenates all words of sentences and then calls _get_ngrams(n, words).
I correct _get_word_ngrams() code that the sentences will not be concatenated.