Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid to add empty space between words and punctations. #178

Merged
merged 4 commits into from
Jul 30, 2022

Conversation

gianpd
Copy link
Contributor

@gianpd gianpd commented Jul 11, 2022

This small fix, avoid to add empty space between words and punctation symbols. I realized that there were annoying spaces in the final text.

Copy link
Owner

@miso-belica miso-belica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the test cases for this fix? Thank you

@mrx23dot
Copy link

I have never seen extra spaces added, do you have example?

Copy link
Owner

@miso-belica miso-belica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check my comments. I am what is the critical part in the test.

tests/test_html_parser.py Outdated Show resolved Hide resolved
tests/test_html_parser.py Outdated Show resolved Hide resolved
@gianpd
Copy link
Contributor Author

gianpd commented Jul 28, 2022

Hi, any problem with the merge ?

@miso-belica
Copy link
Owner

Yes, sorry, the time is my problem. I hope I get to this soon.

@gianpd
Copy link
Contributor Author

gianpd commented Jul 28, 2022

Yes, sorry, the time is my problem. I hope I get to this soon.

Ok, no problem, thanks!

Copy link
Owner

@miso-belica miso-belica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your fix and your patience with me 🙂

@miso-belica miso-belica merged commit 392f5b8 into miso-belica:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants