Greek stemmer bug fix #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NC0DER can you please allow me to update your PR? There should be checkbox for it. I need to rebase the branch on main. Or please rebase it. |
|
@miso-belica I found the checkbox titled "Allow edits by maintainers" and enabled this setting. Sorry for this inconvenience. If anything else is required, please let me know. |
miso-belica
force-pushed
the
GreekStemmerBugFix
branch
from
790a24d
to
a7553dd
Compare
|
I had to remove Python v3.5 from CI. But it is dead anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
As mentioned in issue #173 I added a test to reproduce the empty stem bug of the greek stemmer.
I committed the test case first as to reproduce the bug, and then in the next commit I added the bug fix.
If you got any feedback, please let me know.
Thank you for your time.