Add italian and explicit support Python 3.7 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the README has a note about how to run tests locally, possibly within a virtual environment.
|
The CI pipeline fails for a random network error within Travis build, restarting it manually it works |
miso-belica
requested changes
Oct 26, 2018
There was a problem hiding this comment.
@jacopofar Hi and thanks for the PR. Please look at my comments and then I will happily merge it :)
Data licensed under MIT, from: https://github.com/stopwords-iso/stopwords-it Bump version, add Italian to the natural languages
--use-wheel was deprecated, and its usage breaks the test. Use a version of pytest-cov which supports python 3.3
pytest and pytest-cov do not support Python 3.3 anymore. Since Python 3.3 is EOL, I think it's easier to just remove it from test targets.
jacopofar
force-pushed
the
add-italian
branch
from
960b7c0
to
286cfda
Compare
Stopwords list contained many words which are not actually stopwords but are simply very frequent. Manually removed them.
jacopofar
force-pushed
the
add-italian
branch
from
286cfda
to
9a6d343
Compare
|
Applied the required changes, thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added explicit support for Python 3.7 and for the Italian natural language using a MIT-licensed stopword list.
Python 3.3 reached EOL and is not supported by
pytestandpytest-cov, so I dropped it from test targets.Also, I added to the readme a short explanation about running tests locally on a virtualenv.