Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename create_crop_hash to update_crop_hash #1

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

misfist
Copy link
Owner

@misfist misfist commented Aug 24, 2023

Patches failed on 6.4.
Updated patch for WP 6.4.

Trac ticket: add_image_sizes does not create the "crop position" versions of the image


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@misfist misfist merged commit 6237bc1 into 40370-refresh-at-6-4 Aug 24, 2023
@misfist misfist deleted the 40370-refresh-at-6-4-update branch August 24, 2023 21:13
misfist added a commit that referenced this pull request Aug 24, 2023
Patch applied
40370.diff​ (4.7 KB) - added by themattroyal 5 years ago
patching file src/wp-includes/class-wp-image-editor-gd.php
Hunk #1 succeeded at 153 with fuzz 1 (offset 17 lines).
Hunk #2 FAILED at 225.
Hunk #3 FAILED at 256.
Hunk WordPress#4 succeeded at 557 with fuzz 2 (offset 105 lines).
2 out of 4 hunks FAILED
misfist added a commit that referenced this pull request Sep 21, 2023
patching file src/wp-includes/class-wp-image-editor-gd.php
patching file src/wp-includes/class-wp-image-editor-imagick.php
patching file src/wp-includes/class-wp-image-editor.php
patching file tests/phpunit/tests/media.php
Hunk #1 succeeded at 1362 (offset -1 lines).

Update descriptions

Update WP version

5.1.0 >6.4.0

Auto-fix code formatting
@misfist misfist mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant