Rename create_crop_hash to update_crop_hash
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misfist
added a commit
that referenced
this pull request
Aug 24, 2023
Patch applied 40370.diff (4.7 KB) - added by themattroyal 5 years ago patching file src/wp-includes/class-wp-image-editor-gd.php Hunk #1 succeeded at 153 with fuzz 1 (offset 17 lines). Hunk #2 FAILED at 225. Hunk #3 FAILED at 256. Hunk WordPress#4 succeeded at 557 with fuzz 2 (offset 105 lines). 2 out of 4 hunks FAILED
misfist
added a commit
that referenced
this pull request
Sep 21, 2023
patching file src/wp-includes/class-wp-image-editor-gd.php patching file src/wp-includes/class-wp-image-editor-imagick.php patching file src/wp-includes/class-wp-image-editor.php patching file tests/phpunit/tests/media.php Hunk #1 succeeded at 1362 (offset -1 lines). Update descriptions Update WP version 5.1.0 >6.4.0 Auto-fix code formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches failed on 6.4.
Updated patch for WP 6.4.
Trac ticket:
add_image_sizesdoes not create the "crop position" versions of the imageThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.