This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Remove extra symbols from complex formattings sentence. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, the problem that it depends how Markdown would treat I would think to always add space after closed notation, but it would lead to double spaces. As you see the original sentence has 2 formats in same time italic + bold. |
miry
added a commit
that referenced
this pull request
Jul 26, 2022
miry
added a commit
that referenced
this pull request
Jul 26, 2022
|
I have a bit modified the code to ignore empty links, like it was done in Medium. Also swap closing elements with last space. |
miry
added a commit
that referenced
this pull request
Jul 26, 2022
Overlapping style and link tags could produce an incredible Markdown. Because of WYSIWYG, plenty of hidden things that could destroy Markdown. Introduce a workaround to have swap places last space and closing elements. Ignore links without anchor text. There are still more possibilities to break Markdown. Old render: ```markdown ***Paul Keen** is a Chief Technology Officer at [JetThoughts](https://www.jetthoughts.com). Follow him on[ *](https://twitter.com/ChrisKeathley)[LinkedIn](https://www.linkedin.com/in/paul-keen/) *or [GitHub](https://github.com/pftg).* ``` New render: ```markdown ***Paul Keen** is a Chief Technology Officer at [JetThoughts](https://www.jetthoughts.com). Follow him on* [LinkedIn](https://www.linkedin.com/in/paul-keen/) *or [GitHub](https://github.com/pftg).* ```
miry
force-pushed
the
59-fix-wysiwyg-formatting
branch
from
9728525
to
a8c5582
Compare
Overlapping style and link tags could produce an incredible Markdown. Because of WYSIWYG, plenty of hidden things that could destroy Markdown. Introduce a workaround to have swap places last space and closing elements. Ignore links without anchor text. There are still more possibilities to break Markdown. Old render: ```markdown ***Paul Keen** is a Chief Technology Officer at [JetThoughts](https://www.jetthoughts.com). Follow him on[ *](https://twitter.com/ChrisKeathley)[LinkedIn](https://www.linkedin.com/in/paul-keen/) *or [GitHub](https://github.com/pftg).* ``` New render: ```markdown ***Paul Keen** is a Chief Technology Officer at [JetThoughts](https://www.jetthoughts.com). Follow him on* [LinkedIn](https://www.linkedin.com/in/paul-keen/) *or [GitHub](https://github.com/pftg).* ```
miry
force-pushed
the
59-fix-wysiwyg-formatting
branch
from
a8c5582
to
cdf01ed
Compare
miry
changed the title
|
Example of changes after that PR: miry/miry.github.io@4a19558 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original post: https://jtway.co/speed-up-your-rails-test-suite-by-6-in-1-line-13fedb869ec4
In medium it looks like
But in Markdown has a single
*in front of line:https://github.com/jetthoughts/blog/blob/master/_posts/2017-06-13-speed-up-your-rails-test-suite-by-6-in-1-line.md
For example:
***Paul Keen **is a Chief Technology Officer ...*=>**Paul Keen** is a Chief Technology Officer