-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic v2 #186
Merged
Merged
Pydantic v2 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates version of pydantic to
~2.0
.Changes in generated clients and models:
parse_obj
->model_validate
.dict()
->.model_dump()
Config
classBaseModel
usesmodel_config = ...
attribute.Upload
is no longer dataclass, in v2 pydantic's.model_dump()
changes dataclasses to dicts which is harder for client to detect files.update_forward_refs
->model_rebuild
pydantic.json.pydantic_encoder
->pydantic_core.to_jsonable_python
None
value (if schema doesn't specify another) Feature request: setdefault=None
on optional input type fields #165I see some potential to improve our implementation of custom scalars using some pydantic's v2 features, but this pr is already huge so it aims to sustain the same logic.
resolves #183 #165