minor code cleanups#429
Merged
Merged
Conversation
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 14, 2021
CHANGES: * Remove static RSA and CBC ciphersuites from default configuration. The default configuration now includes FFDHE and ECDHE key exchanges with RSA or ECDSA/EdDSA certificates, and AEAD ciphers (AES-GCM, AES-CCM, ChaCha20-Poly1305) (mirleft/ocaml-tls#429 by @hannesm) * Remove SHA1 from signature_algorithms in the default configuration (mirleft/ocaml-tls#429 by @hannesm) * Support ECDSA and EdDSA certificates and private keys via x509 0.12.0 and mirage-crypto-ec (mirleft/ocaml-tls#428 by @hannesm) Breaking changes: - the second part of type Tls.Config.certchain is now a X509.Private_key.t (previously Mirage_crypto_pk.Rsa.priv) - the type aliases X509_lwt.priv and X509_lwt.authenticator have been removed * Use mirage-crypto-ec instead of fiat-p256 and hacl_x25519 for elliptic curve support - this adds P384 and P521 ECDH support (mirleft/ocaml-tls#428 by @hannesm) * Remove custom Monad implementation, use Result and Rresult instead (mirleft/ocaml-tls#429 by @hannesm) * Remove Utils.Cs submodule, use Cstruct API instead (mirleft/ocaml-tls#429 by @hannesm) * Breaking: Tls.Engine.ret type is now a result instead of a custom variant type (mirleft/ocaml-tls#429 by @hannesm) * Breaking: Tls_lwt.Unix.epoch results in (Tls.Core.epoch_data, unit) result - it was a custom error type previously (mirleft/ocaml-tls#429 by @hannesm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is on top of #428, and does some code cleanups (using result).