Yet more sexps

[pqwy]

Gets rid of the local cstruct pretty-printing code, delegates to the more compact native version.

Merging should probably wait for mirage/ocaml-cstruct#44, but this is what Piñata runs right now.

[avsm]

if this is an error, why not just expose only sexp_of below?

[pqwy]

One, to get downstream types to use with sexp and avoid the boilerplate of writing [one side of] it by hand. Two, because this is expected to be fixed eventually (it's in a (* Sexplib stubs *) ... (* *** *) comment block), and it's nice to have the API, even if sketched out.

Note that all these types should be invisible to the outside. This is all basically for tracing/debugging.

[hannesm]

now that cstruct-1.6.0 is out, could you rebase? then we could merge and be happy..

[avsm]

And update the opam file constraint at same time as rebase

On 28 Apr 2015, at 19:56, Hannes Mehnert notifications@github.com wrote:

now that cstruct-1.6.0 is out, could you rebase? then we could merge and be happy..

—
Reply to this email directly or view it on GitHub.

[pqwy]

Rebased.

But once merged, it will require the unreleased mirage-xen 2.3.2 with support for cstruct 1.6.0.

ping @avsm

[hannesm]

thanks!