Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tab behavior to keep one open at all times #205

Merged
merged 1 commit into from
May 4, 2024

Conversation

nikhilraojl
Copy link
Contributor

closes #204 & minor context menu UI issue

fix issue 204

This change does not show x remove tab button if there is only one tab.

  • when extension is opened for first time
    image

  • after clicking on new tab +
    image

  • after closing one of the two tabs
    image

context menu UI issue

This change also includes one minor UI issue. Removes empty li in bookmark context menu. I included it here as it is a small change. Can split it up into new PR if needed
326423266-8362aa0d-430a-4749-90ac-8f8cfe04be23

@mirkoperillo mirkoperillo merged commit c0c6c5d into mirkoperillo:master May 4, 2024
1 check passed
@mirkoperillo
Copy link
Owner

Thank you @nikhilraojl for the catch and the fix, well done...PR merged

@nikhilraojl nikhilraojl deleted the fix_204 branch May 5, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior of tabs
2 participants