Fix initialiser location #2574
Open
Fix initialiser location #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
relocate-initializer
branch
from
dd0e72a
to
ae591bb
Compare
| @@ -106,8 +106,8 @@ module.exports = { | |||
| }); | |||
| }, | |||
|
|
|||
| treeForApp(appTree) { | |||
| let trees = [appTree]; | |||
| treeForAddon(addonTree) { | |||
There was a problem hiding this comment.
@mansona could you please explain a bit this change?
I got the point about initializer location in app folder and that totally makes sense. But this change seems separate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the main initialiser in the app folder means that a consuming app can't actually override the initialiser.
This means that you can't have an embroider safe implementation that works in Fastboot, because we can't have a fastboot-specific ember-cli-mirage initialiser that doesn't (eventually) import pretender. This means that even though pretender doesn't actually work in node there is no way to prevent it being imported in your app, until this PR is merged 👍