-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
➖ Remove lodash
dependency
#2421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
Prettier gets me every time. Want to add lint-staged to the git commit hook to run it for me 😄 |
@SergeAstapov I've ran |
@bartocc the stack trace makes me think the issue caused by some transitive dependency that got drifted:
however <=3.24 scenarios fail with different error
I just saw that exact same error in https://github.com/miguelcobain/ember-css-transitions/runs/6711631246?check_suite_focus=true which makes me think it's again comes from transitive dependency. I don't have time right to look into root cause, will try to do once I have a chance. |
@SergeAstapov any idea how I could help debug the CI? |
# Conflicts: # packages/ember-cli-mirage/package.json # yarn.lock
Thank you @bartocc! |
➖ Remove `lodash` dependency
I might be wrong, but this is the only place in the codebase where we use a lodash function.
lodash is quite big, and even if ember-cli-mirage is only bundled in dev/test builds, this could be refactored with
typeof
and we could completely drop thelodash
dependency…