Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS declaration for setupMirage #2366

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

dfreeman
Copy link
Contributor

This PR ensures that import { setupMirage } from 'ember-cli-mirage/test-support'; works as expected for TypeScript users. It also adds a small types-tests suite to verify that they work as expected.

@SergeAstapov if I were to open a second copy of this PR against the v2 branch, is there a chance you'd be willing to include it in a 2.x release as well, since 3.0 is still in alpha? 🙂

@SergeAstapov
Copy link
Collaborator

SergeAstapov commented Feb 21, 2022

@SergeAstapov if I were to open a second copy of this PR against the v2 branch, is there a chance you'd be willing to include it in a 2.x release as well, since 3.0 is still in alpha? 🙂

Yes! I'm 100% up for this as v2 is still fully supported and I think we'll support it for some time until v3 surpasses v2

@SergeAstapov SergeAstapov merged commit 806aee5 into miragejs:master Feb 21, 2022
@dfreeman dfreeman deleted the type-declarations branch February 21, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants