-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FastBoot 1.0 #1098
Fix FastBoot 1.0 #1098
Conversation
The failing scenario in Travis seems to be not related, a rerun should hopefully fix this! Will have to look at the codeclimate complains though... |
@simonihmig rerunning that one failed scenario. |
@simonihmig looks like the CI gods have accepted our offering. You may want to look into the codeclimate stuff though. |
Awesome -- thank you very much! (This would have taken me ages..) I got rid of codeclimate so no worries there (it was too noisy) 🙇 |
@samselikoff can we get a release with this? please 😛 |
Awesome, thanks! |
@samselikoff @simonihmig Are there specific blockers/complications that require mirage to be disabled in fastboot? This seems to impede development quite a bit when running |
@billdami sorry, missed your question. Basically, Mirage works be using pretender.js to intercept ajax requests and fake the response. In FastBoot however this does not work, as there is no Ajax in node.js, HTTP requests are made with node APIs. I am very much looking forward to a world where Mirage would work in FastBoot out of the box, as probably many others. But it's not there yet. And this is unrelated to this PR. I believe #1014 would solve that issue, but no idea how this is going forward... |
The upcoming FastBoot 1.0 (incl. latest RC versions) include breaking changes, that don't work anymore with ember-cli-mirage. See ember-fastboot/ember-cli-fastboot#387
This adds FastBoot tests (just testing that it does not break FastBoot rendering. They were failing at first with the latest FastBoot releases), and the required changes.
Note: I set
engine
to>= 4
to be able to use some ES6 in node. Hope that is ok!