Skip to content

Fixed compilation issue with js_of_ocaml 3.5.0 and 3.5.1.#140

Merged
mseri merged 2 commits into
mirage:masterfrom
vycastor:fix_jsofocaml
Nov 29, 2019
Merged

Fixed compilation issue with js_of_ocaml 3.5.0 and 3.5.1.#140
mseri merged 2 commits into
mirage:masterfrom
vycastor:fix_jsofocaml

Conversation

@vycastor
Copy link
Copy Markdown
Contributor

Because of ocsigen/js_of_ocaml#863 the build failed with the latest versions of js_of_ocaml.

@mseri
Copy link
Copy Markdown
Collaborator

mseri commented Nov 29, 2019

Thanks! Can you add a lower bound on js_of_ocaml 3.5.0 in the opam file as well?

@mseri
Copy link
Copy Markdown
Collaborator

mseri commented Nov 29, 2019

Thanks!

@mseri mseri merged commit 3e366b6 into mirage:master Nov 29, 2019
@vycastor vycastor deleted the fix_jsofocaml branch December 3, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants