All commits

[Stevendeo]

Adding a 'get_all_commits' request

[avsm]

Thanks for the PR! I've pushed a merge commit to get the CI green on your branch.

[Stevendeo]

Thanks!

[tmcgilchrist]

@Stevendeo the linting issue is fixed on master if you want to merge again (or rebase).

[tmcgilchrist]

Thanks for the PR @Stevendeo. I suggest you use the Stream module, comments inline.
Git rebase/merge/cherry-pick the branch and I can merge it.

The releases.ml test code uses a streamed listing of releases in a repository, as an example of how to consume s 'a Stream.t

[tmcgilchrist]

This could be improved by using Stream.t since the response is paginated, the Stream module provides an abstraction over GitHub's paginated endpoints.

Suggested change

	val get_commits :
	?token:Token.t ->
	user:string -> repo:string ->
	unit -> Github_t.commits Response.t Monad.t
	(** [get_commits ~user ~repo ()] lists all commits in [user]/[repo]. *)
	val get_commits :
	?token:Token.t ->
	user:string -> repo:string ->
	unit -> Github_t.commit Stream.t
	(** [get_commits ~user ~repo ()] stream of all commits in [user]/[repo]. *)

[tmcgilchrist]

Using get_stream this should be something like

Suggested change

	let get_commits ?token ~user ~repo () =
	let uri = URI.repo_commits ~user ~repo in
	API.get ?token ~uri (fun b -> return (commits_of_string b))
	let get_commits ?token ~user ~repo () =
	let uri = URI.repo_commits ~user ~repo in
	let fail_handlers = [
	API.code_handler
	~expected_code:`Not_found
	(fun _ -> Lwt.return [])
	] in
	API.get_stream ?token ~uri ~fail_handlers (fun b -> return (commits_of_string b))

[Stevendeo]

Thanks for the review, I just fixed my commit with the Stream module